-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Navigate visible history #3591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Navigate visible history #3591
Conversation
Why do we need a |
Because it differs from what is in the tree, it shows full types, members including type, and assembly name for some of the folders (screenshot first item) |
I can also imagine it could be a method where you put current state and the text would differ on where you are (like same namespace or same assembly) |
I think I am fine with that. Does need to be in the |
It's also important to use the settings-aware implementation for the node text that is used everywhere else. |
It has a default implementation returning You can see in the changed files that it follows what With that said, I don't mind using |
Maybe put the folder in parentheses? I am not sure. I can have a closer look when I get home. Reviewing code on the phone is not ideal. 😅 |
I put the folder first and where it belongs in parentheses, looks better, see the updated screenshot. |
I also tried to include module name in the metadata nodes but feel free to skip that commit. Done working on this PR until there is feedback to address. |
One thought I had: is it possible to get an actual dropdown toolbar button in WPF? Is this only included in some community library? |
There is no built-in dropdown button in WPF. I considered creating a control for it (or retemplating combobox) but since the theme and styles are external it didn't seem worth it. We could also just have it as context menu on the normal buttons and that's it. |
Implements #3582 to show history items:
@aybe